Support Rails 7.2 #255
Merged
Support Rails 7.2 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blowmage Any chance this could be released soon? |
bquorning
reviewed
Oct 29, 2024
olivier-thatch
force-pushed
the
olivier-rails-7-2
branch
from
7c58b7e to
1515404
Compare
|
@blowmage nudge |
|
Hi there! Any news? ping @blowmage |
|
Based off of this branch, I opened #258 to add support for Rails 8.0 too. |
zenspider
requested changes
Nov 27, 2024
|
Also I understand if it's been too long... I'm happy to make the changes requested. |
olivier-thatch
force-pushed
the
olivier-rails-7-2
branch
from
1515404 to
954e3df
Compare
|
@zenspider Made the requested changes. |
olivier-thatch
force-pushed
the
olivier-rails-7-2
branch
2 times, most recently
from
8a91008 to
0ea44aa
Compare
|
Hi there! Any news? |
|
I'm on it |
zenspider
approved these changes
Dec 18, 2024
|
All the 7.2 tests passed and all the 7.1 tests failed, presumably because they have too old of a ruby version? I am trying to make sense of this but since the 7.2 tests are passing I'mma consider this good and I'll fix the CI out of band. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Rails 7.2
Rails 7.2 was released a few weeks ago. This PR upgrades minitest-rails accordingly.
Note that Rails 7.2 bumped the minimum Ruby version from 2.7 to 3.1, so I've done the same here.