Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that evaluateScript() has specific needs #742

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Document that evaluateScript() has specific needs #742

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f2935
Document that evaluateScript() has specific needs
timplunkett Oct 16, 2017
a728124
Expand docs and copy to DriverInterface.
timplunkett Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,10 @@ public function executeScript($script)
/**
* Execute JS in browser and return it's response.
*
* The "return" keyword is optional in the script passed as argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an actual example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/minkphp/driver-testsuite/blob/master/tests/Js/JavascriptEvaluationTest.php for the tests

* Multiline scripts must be wrapped in an immediately-invoked function
* expression.
*
* @param string $script javascript
*
* @return string
Expand Down