added pressKey, deprecated keyPress/keyDown/keyUp

[oleg-andreyev]

Ref.: minkphp/MinkSelenium2Driver#304 (comment)

that's not the same API than previously. After calling keyDown, your implementation already released the key.

I think we should rather add a new pressKey method in Mink, and deprecate these 3 methods. And the new version of the driver would then implement only pressKey.

And we should implement the new method in 1.x too
The old implementation was not good anyway, as it was not actually pressing the key, but only triggering the JS actions (so the default behavior of pressing a key would not happen).

[stof]

please also open a PR for the driver-testsuite repo to cover pressKey

[oleg-andreyev]

@stof minkphp/driver-testsuite#30

[aik099]

I recommend releasing all current features as 1.7.2 version and only then merging this PR which will force next release to be 1.8.0.

[oleg-andreyev]

@aik099 I’m okay 1.7.2 will just PR probably tomorrow

[aik099]

@aik099 I’m okay 1.7.2 will just PR probably tomorrow

@oleg-andreyev , according to #725 @greg-1-anderson is also wanting to help out with a PR. I'll let him do that.

[greg-1-anderson]

I took a swag at making an updated changelog in #786. If anyone wants to improve it, feel free; I am unfamiliar with the conventions used in this project, and just made my best effort based on previous entries.