Add fieldValueMatches / fieldValueNotMatches#775
Open
das-peter wants to merge 1 commit intominkphp:masterfrom
Open
Add fieldValueMatches / fieldValueNotMatches#775das-peter wants to merge 1 commit intominkphp:masterfrom
das-peter wants to merge 1 commit intominkphp:masterfrom
Conversation
Squash: * Added tests. * Fixed inversion of condition. * Add fieldValueMatches / fieldValueNotMatches Would be hand to allow pattern assertions on field values like on the page text. This was mentioned here minkphp#696 but: "PR got lost in the sands of time" :)
Author
|
Added tests, based on testPageTextMatches / testPageTextNotMatches / testFieldValueEquals / testFieldValueNotEquals. Edit: Commits have been squashed. |
aik099
approved these changes
Jun 3, 2019
Member
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be hand to allow pattern assertions on field values like on the page text.
This was mentioned here #696 but: "PR got lost in the sands of time" :)