feat: initial metric client implementation#4
Merged
Conversation
jvanschie
force-pushed
the
feature/599-metric-service
branch
from
May 18, 2026 14:28
44480ed to
f680db7
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
jvanschie
force-pushed
the
feature/599-metric-service
branch
8 times, most recently
from
May 20, 2026 12:37
88221de to
a8897ae
Compare
jvanschie
marked this pull request as ready for review
May 20, 2026 14:50
jvanschie
force-pushed
the
feature/599-metric-service
branch
4 times, most recently
from
May 20, 2026 15:10
164824e to
5454693
Compare
MelchiorKokernoot
previously approved these changes
May 21, 2026
jvanschie
force-pushed
the
feature/599-metric-service
branch
from
May 21, 2026 10:35
5454693 to
ea49573
Compare
jvanschie
force-pushed
the
feature/599-metric-service
branch
from
May 21, 2026 10:44
ea49573 to
7f9d14e
Compare
|
MelchiorKokernoot
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Change Description
Introduced
mgo-metric-service, a Python metrics client library that decouples application code from metrics backends. Applications emit counters, gauges, and timings through a singleMetricsClientAPI, with pluggable backends (StatsD,in-memory,no-op) and formatters for metric keys and tags.Changes Made
MetricsClientwith incr, gauge, and timing methods, optional tag support, and debug loggingStatsDBackend(StatsD over UDP),InMemoryBackend(records calls for inspection), andNoopBackend(discards metrics)StatsDFormatter(dot-separated keys with tag validation),InMemoryFormatter(human-readable keys for tests), andNoopFormatterformatting nothing.FakeMetricsClientwithassert_metric_call,assert_incr,assert_gauge,assert_timing, andresetfor test assertionsmake check(lint, format, mypy, pytest with coverage)README.mdwith installation, usage examples, and testing guidanceTesting Instructions for QA Team
This is a Python library, not a deployable HTTP service.
Verification is through automated checks or library usage.
Checklist