Open
Conversation
dinosaure
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I propose this tiny addition of a testable for Uchar.t values.
There is a non-obvious question of how to print such values. Currently the stdlib has neither a formatter for uchars nor a literal syntax to read them back (see upstream discussion here), so it is not possible to provide a directly useable value. I am reusing
Fmt.Dump.ucharwhich doesFmt.pf ppf "U+%04X" (Uchar.to_int uc), for instance "é" becomesU+00E9. To read it back (for instance in the toplevel) you need to writeUchar.of_int 0x00E9.Some options:
"\u{00E9}"(this is a valid string value)%CBut I'm not convinced by any of these, if you're using uchar's you're probably doing something fairly technical and a pure code is good enough for debugging.