Minor_allocated: Use Gc.minor_words#54
Open
Julow wants to merge 1 commit intomirage:mainfrom
Open
Conversation
Minor_allocated was showing a result of 0.0000 mnw/run, possibly because my benchmarks weren't triggering minor collections. With this change, the results seems more accurate but the R² is low (printed on a red background in the notty output). The R² seems unchanged for tests that trigger minor collections.
Member
|
I think it's also related to #60, can you take a look on this PR with your commit and see what result you have? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor_allocatedwas showing a result of0.0000 mnw/run, possibly because my benchmarks weren't triggering minor collections.With this change, the results seems more accurate but the R² is low (printed on a red background in the notty output).
The R² seems unchanged for tests that trigger minor collections.
What do you think ?