Renewal - #158
Open
reynir wants to merge 12 commits into
Open
Conversation
hannesm
reviewed
Jul 31, 2026
| do_renew lease | ||
| | `T2_rebinding -> | ||
| (* TODO *) | ||
| failwith "oh no" |
Member
There was a problem hiding this comment.
this should be fixed before merge, or?
Member
Author
There was a problem hiding this comment.
Yes. We likely need a timer on Ip_lease_time secs as well
reynir
marked this pull request as draft
July 31, 2026 10:54
reynir
commented
Jul 31, 2026
reynir
left a comment
reynir
left a comment
Member
Author
There was a problem hiding this comment.
I pushed code that implements rebinding and renewing. I think the code @PizieDust added was actually closer to rebinding. I'm not convinced the renew logic is correct (see review comment).
Comment on lines
126
to
134
Member
Author
There was a problem hiding this comment.
I'm not so convinced of this. For RENEWING RFC 2131 4.3.2 says:
This message will be unicast, so no relay agents will be involved in its transmission.
I think when renewing we don't need to care about other DHCP servers being present.
reynir
marked this pull request as ready for review
August 13, 2026 10:45
There might otherwise be a race condition?!
If the uint32 doesn't fit in an int we use max_int instead. Waiting ~34 years instead of up to ~136 years is likely not a big issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.