Skip to content

Error on attempts at writing martian packets #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reynir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Error on attempts at writing martian packets #538

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800fe96
Error on attempts at writing martian packets
reynir Feb 24, 2026
8220f11
Also error in ipv6 when attempting to write to ::1
reynir Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ipv4/routing.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ module Make(Log : Logs.LOG) (A : Arp.S) = struct
Log.info (fun f -> f "IP.output: %a" A.pp_error e);
Error `Local
end
|ip when Ipaddr.V4.Prefix.mem ip Ipaddr.V4.Prefix.loopback -> (* Loopback *)
Lwt.return (Error `Loopback)
|ip -> (* Gateway *)
match gateway with
| None ->
Expand Down
3 changes: 3 additions & 0 deletions src/ipv4/static_ipv4.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ module Make (Ethernet: Ethernet.S) (Arpv4 : Arp.S) = struct
| Error `Local ->
Log.warn (fun f -> f "Could not find %a on the local network" Ipaddr.V4.pp dst);
Lwt.return @@ Error (`No_route "no response for IP on local network")
| Error `Loopback ->
Log.warn (fun f -> f "Write to loopback %a dropped" Ipaddr.V4.pp dst);
Lwt.return @@ Error (`No_route "Loopback address")
| Error `Gateway when t.gateway = None ->
Log.warn (fun f -> f "Write to %a would require an external route, which was not provided" Ipaddr.V4.pp dst);
Lwt.return @@ Ok ()
Expand Down