Skip to content

let's not install empty META files - #187

Open
hannesm wants to merge 2 commits into
mirage:mainfrom
hannesm:rm-is-solo5
Open

let's not install empty META files#187
hannesm wants to merge 2 commits into
mirage:mainfrom
hannesm:rm-is-solo5

Conversation

@hannesm

@hannesm hannesm commented Aug 25, 2026

Copy link
Copy Markdown
Member

for both is_freestanding (earlier is_solo5) and nolibc, there's with current mirage (and mkernel) workflow no need to have META files installed. I tested this with e.g. qubes-mirage-firewall. Would be great if this can be tested and approved by someone else as well.

@hannesm

hannesm commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

I actually think that threads is also misguided, and we may not need that at all. I'll do some experiments.

@hannesm

hannesm commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

See the last commit, still compilation succeeds (of the various unikernels mentioned earlier). I think this was leftovers from mirage3 where ocamlfind was used extensively. These days, all of that can be removed (and thus reducing complexity and wrong information, such as type_of_threads = "posix").

As said, if someone (or more than one) can confirm this, it would be good.

@palainp palainp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hannesm, more is less and less is more!

I tested with success for qubes-mirage-firewall (as you did) and another Xen unikernel. So I approve your changes :D

@hannesm hannesm changed the title let's only install a META for threads let's not install empty META files Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants