let's not install empty META files - #187
Open
hannesm wants to merge 2 commits into
Open
Conversation
Member
Author
|
I actually think that threads is also misguided, and we may not need that at all. I'll do some experiments. |
Member
Author
|
See the last commit, still compilation succeeds (of the various unikernels mentioned earlier). I think this was leftovers from mirage3 where ocamlfind was used extensively. These days, all of that can be removed (and thus reducing complexity and wrong information, such as As said, if someone (or more than one) can confirm this, it would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for both is_freestanding (earlier is_solo5) and nolibc, there's with current mirage (and mkernel) workflow no need to have META files installed. I tested this with e.g. qubes-mirage-firewall. Would be great if this can be tested and approved by someone else as well.