on second thought - #2
Open
zapnap wants to merge 1 commit into
Open
Conversation
Member
|
So this is just casting nil upfront? I think the typer is smart enough to not need that. eg on compilation, I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems to me that a type shouldn't be assigned on variable initialization if the assignment is to nil / null. perhaps this failure is intentional? still seems odd / like a bug. but i'm new to mirah, so it may be that this is just a naive point of view. clarification would be awesome -- thanks in advance!