Skip to content

Conversation

@lihaohong6
Copy link

Use codex design tokens to replace hard-coded colors for Special:RequestWikiQueue details.

Tested on Chrome/Firefox's dev tools.

@coderabbitai
Copy link

coderabbitai bot commented Sep 14, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Universal-Omega Universal-Omega self-requested a review September 15, 2025 01:07
@lihaohong6
Copy link
Author

Looks like CI wants me to change border-color: var(--border-color-base, #c8ccd1); into border-color: var( --border-color-base, #c8ccd1 );, which is pretty silly since MDN doesn't do that. I do see some WMF repos such as vector add spaces like that, so maybe I'll submit to the almighty CI.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.16%. Comparing base (8f3deec) to head (c07881a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #777   +/-   ##
=========================================
  Coverage     31.16%   31.16%           
  Complexity      811      811           
=========================================
  Files            47       47           
  Lines          3924     3924           
=========================================
  Hits           1223     1223           
  Misses         2701     2701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Universal-Omega Universal-Omega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so, while this may work, we should probably use LESS tokens. To do so, add
@import 'mediawiki.skin.variables.less'; at the top then for example, instead of var( --border-color-subtle, #ccc ) use @border-color-subtle.

Use codex design tokens to replace hard-coded colors for Special:RequestWikiQueue details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants