Revise default target blank #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It breaks the search, as the dummy hash `#` link for the search is also opened in a new tab, where the search box does not even appear. * It would also open internal links (including section hashes) to the r-techguides in a new tab. * Also purge the unnecessary `pandoc_args`. This reverts part of what was done in commit 58105c3.
Batch regex replacement of
(\[[^\]]+\]\(http[^)]+\))
with
$1{target="_blank"}
|
@RolandASc, You can verify the search is fully functional by serving the website locally via |
RolandASc
reviewed
Mar 25, 2025
* Multiline links were not captured in the batch regex replacement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the default opening of all links in a new tab (
target="_blank") done in #50 (58105c3)#link for the search is also opened in a new tab, where the search box does not even appear.pandoc_args, introduced in the same commit.Instead, all external links have an explicit
target="_blank"(\[[^\]]+\]\(http[^)]+\))=>$1{target="_blank"}