Skip to content

Revise document path for Git modified date child document #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

riccardoporreca
Copy link
Member

  • By using knit_child() explicitly and placing the path in the environment used for rendering the child.
  • To replace the need for writing to a file and using multiple chinks.

This is an approach we used already in the first MiraiLabs: From prototype to production

* By using `knit_child()` explicitly and placing the path in the environment used for rendering the child.
* To replace the need for writing to a file and using multiple chinks.
@riccardoporreca riccardoporreca force-pushed the feature/26-revise-git-modified-date branch from 0c34156 to ae3421a Compare March 25, 2025 08:59
* Note that we use `mod-date` in the parent document and we cannot re-use it in the child.
Copy link
Member

@RolandASc RolandASc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riccardoporreca riccardoporreca merged commit 5c9a13a into master Mar 25, 2025
4 checks passed
@riccardoporreca riccardoporreca deleted the feature/26-revise-git-modified-date branch March 25, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants