Adding limited font style support #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat matches xlconnect-java branch with color support
|
Hi @deppemj , thanks a lot for your PRs! Basic font formatting would be a useful feature to include in XLConnect. We will try to review this in detail but don't have a lot of time at the moment. One thing that would be desirable (and that we do not have yet) would be a way to unit test these changes. As a first step, just exercising the code to repeatably check that there are no unexpected runtime errors would be good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never pushed code to someone else's codebase before, no clue if this code quality is something you would accept or if I should just keep it on my own fork.