Add possibility to configure Apache POI #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoltier
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
- Looking at the POI reference you linked in the doc, should we also have a setting for
setThresholdBytesForTempFiles? Even if we would leave the default of not using temp files (in case we run on a readonly system), it seems like this may sometimes be needed when using large files. - I understand it would be wasteful to have a happy-path test that uses a large file, but we could have negative tests which check that an exception is produced after setting some config value to an arbitrarily low level. This could alert us to some potential future changes in behavior of these config options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function
configurePOIthat allows to configure Apache POI according to configuration options documented at https://poi.apache.org/components/configuration.html.