Fix memory leak caused by auto panning timer #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a memory leak by ensuring the auto-panning timer is stopped and its event handlers removed when the editor unloads. Key changes include stopping/clearing the timer on unload, refactoring the timer setup/teardown logic, and updating related example code and documentation.
- Subscribes to the editor’s
Unloadedevent and disables auto-panning when the control is unloaded - Refactors
OnDisableAutoPanningChangedto clear existing timers and detach its tick handler before recreating - Updates example project to use a dedicated
OperationsMenuHandlerand adds a changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Nodify/Editor/NodifyEditor.cs | Added Unloaded subscription and handler to disable auto-panning |
| Nodify/Editor/NodifyEditor.Panning.cs | Refactored timer logic: clear old timer, detach handler, recreate |
| Examples/Nodify.Calculator/EditorView.xaml.cs | Introduced OperationsMenuHandler and updated registration logic |
| CHANGELOG.md | Added entry for auto-panning timer memory‐leak fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
Fix memory leak caused by auto panning timer.
Related #218
🐛 Possible Drawbacks
None that I can think of.