fix: Include model_rebuild for input types as well
#283
+52
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup from mirumee#278 and mirumee#276. We added back support to call `model_rebuild` when needed for result types but didn't add it for input types. Since input types can also require model rebuild when containing nested fields we need to call `include_model_rebuild` for these types as well.
rafalp
suggested changes
Mar 6, 2024
Co-authored-by: Rafał Pitoń <[email protected]>
rafalp
approved these changes
Mar 6, 2024
|
Merged. Its too late to ship this this week, but I'll push it out early next one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #278 and #276. We added back support to call
model_rebuildwhen needed for result types but didn't add it for inputtypes. Since input types can also require model rebuild when containing
nested fields we need to call
include_model_rebuildfor these types aswell.