fix: update websockets #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice! However the quoted part seems like a duplicate of #336. Not that the maintainers seem to actively look at the PRs but decreasing scope and isolate each PR to a single topic is probably a good idea |
|
I thought no one was working on |
mgradalska
force-pushed
the
main
branch
2 times, most recently
from
85dd7d4 to
e49ac6e
Compare
KarolJagodzinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
After upgrading
websockets, application was throwing deprecation warnings. These changes fix the issue, but requirewebsocketsto be upgraded to at least 14.2 version whereClientConnectionwas introduced.Also, fixed deprecatedappargument in httpxAsyncClient.