Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce py3.13, ruff, leverage hatch #359

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Introduce py3.13, ruff, leverage hatch #359

merged 4 commits into from
Feb 26, 2025

Conversation

drozdowsky
Copy link
Contributor

@drozdowsky drozdowsky commented Feb 25, 2025 •
edited
Loading

Addresses: #351

Github actions and pyproject.toml are now similar to what you can see in main Ariadne repo.

Few issues I see:

  • currently auto-generated code is formatted with black+isort (used as imported modules) - this could clash with ruff. I suggest moving to ruff there too.
  • I imagine someone has to configure pypi with new publish flow

@drozdowsky drozdowsky linked an issue Feb 25, 2025 that may be closed by this pull request
chore: introduce python 3.13, ruff... #351
Closed
@drozdowsky drozdowsky marked this pull request as ready for review February 25, 2025 15:00
@KarolJagodzinski KarolJagodzinski merged commit 7648acf into main Feb 26, 2025
5 checks passed
@KarolJagodzinski KarolJagodzinski deleted the 351-chore-introduce-python-313-ruff branch February 26, 2025 09:20
@KarolJagodzinski
Copy link
Contributor

Thanks @drozdowsky for the contribution!

@bombsimon bombsimon mentioned this pull request Feb 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: introduce python 3.13, ruff...
2 participants
@drozdowsky @KarolJagodzinski