test(e2e): fixed and extend checkout happy paths - #538
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
GrzegorzDerdak
changed the title
![prelint[bot]](https://avatars.githubusercontent.com/in/2822344?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Two tests (CHE-02006, CHE-02007) reset between loop iterations using page.goto("http://localhost:3000/gb/checkout/payment") — an absolute hardcoded URL that ignores Playwright's baseURL (driven by...
apps/automated-tests/tests/e2e/checkout/checkout-guest-refactored.spec.ts:1028
Warning
paymentDetails.expiryDate was deliberately computed as 12/${next year} to remain valid over time; it has been replaced with the hardcoded string "12/29".
apps/automated-tests/utils/constants.ts:94
2 finding(s) posted as inline comments.
| ); | ||
|
|
||
| // Step 6: Navigate back to email page | ||
| console.log("\nStep 6: Navigating back to email page"); |
There was a problem hiding this comment.
Caution
Two tests (CHE-02006, CHE-02007) reset between loop iterations using page.goto("http://localhost:3000/gb/checkout/payment") — an absolute hardcoded URL that ignores Playwright's baseURL (driven by TEST_ENV_URL). playwright.config.ts throws hard if TEST_ENV_URL is missing, and every other navigation in the suite uses URLS() + process.env.TEST_ENV_URL; these two calls silently target localhost regardless of the configured test environment, causing the second iteration of each test to run against a different host in CI or staging.
| export const paymentDetails = { | ||
| cardNumber: "4242424242424242", | ||
| expiryDate: `12/${(new Date().getFullYear() + 1).toString().substring(2)}`, | ||
| expiryDate: "12/29", // Verified working expiry date |
There was a problem hiding this comment.
Warning
paymentDetails.expiryDate was deliberately computed as 12/${next year} to remain valid over time; it has been replaced with the hardcoded string "12/29". This value becomes a past expiry in 2030, at which point Stripe will reject it and all payment tests will fail silently with card-validation errors rather than business-logic failures.
|
Nimara migrated to trunk-based development in #718, with |
3 participants
I want to merge this change because...
Pull Request Checklist