Disable vouchers in the marketplace - #737
Draft
lukas-szewczyk wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
On the demo store a discount code could be entered but not removed. Digging in showed a
bigger problem underneath: the code was only ever reducing one seller's part of the basket,
while the summary presented it as a discount on the whole basket. Which seller got it
depended on the order the items happened to be added in.
What this changes
Discount codes are switched off in checkout for shops running in marketplace mode, where
several sellers can share one basket and each seller's order is paid and placed separately.
Single-seller shops — the default setup — keep discount codes exactly as before.
Why we turned it off instead of fixing it
A code covering a whole multi-seller basket is not something the current setup can express.
Making it work is a product decision first: whether discount codes belong to the marketplace
or to individual sellers, and who pays for the discount. Until that is answered, a control
that quietly charges one seller for a basket-wide discount is worse than no control.
The reasoning and the options are written up as a decision record so nobody has to
rediscover them.
Who notices
Marketplace shops lose the discount code field, including the demo store. All other
deployments are unaffected.