Skip to content

build(node): require Node 24.15 - #599

Merged
misaeldasilva123ms96-commits merged 5 commits into
mainfrom
agent/node-24-15-jsdom30
Aug 1, 2026
Merged

build(node): require Node 24.15#599
misaeldasilva123ms96-commits merged 5 commits into
mainfrom
agent/node-24-15-jsdom30

Conversation

@misaeldasilva123ms96-commits

@misaeldasilva123ms96-commits misaeldasilva123ms96-commits commented Aug 1, 2026

Copy link
Copy Markdown
Owner

What changed

  • raise root and frontend Node engines to >=24.15 <25
  • pin .nvmrc and GitHub Actions jobs to Node 24.15.0
  • add explicit Node setup to the release workflow
  • align Docker images and contributor documentation with Node 24.15
  • keep both package lockfiles consistent with the engine contract

Why

Dependabot PR #588 upgrades jsdom to 30, which requires Node ^24.15.0 on the Node 24 line. The project previously declared >=24 <25, workflows and images used an unbounded 24 tag, and release did not set up Node explicitly. This PR makes the runtime contract reproducible before the jsdom upgrade is rebased.

Validation

  • Node 24.15.0 acquired through the published node@24.15.0 runtime package
  • root npm ci — clean, zero vulnerabilities
  • frontend npm ci — clean, zero vulnerabilities
  • frontend npm run typecheck
  • frontend npm run build
  • node scripts/verify-runtime-console.mjs
  • all workflow YAML and package JSON files parsed successfully
  • Docker manifests verified for node:24.15-bookworm-slim, node:24.15-alpine, and node:24.15-slim

The default Vitest fork pool remains unreliable in this Windows environment; the authoritative Linux frontend workflow must pass after publication.

Merge order

  1. Misael reviews and manually merges this PR.
  2. Request @dependabot rebase on build(deps-dev): bump jsdom from 29.1.1 to 30.0.0 in /frontend #588.
  3. Re-run the jsdom 30 frontend audit and confirm all checks at the new SHA before manual merge.

No auto-merge is requested.

Summary by CodeRabbit

  • Chores

    • Standardized development, build, deployment, and runtime environments on Node.js 24.15.0.
    • Updated container images and project requirements to require Node.js 24.15 or later within major version 24.
  • Documentation

    • Updated contributor setup guidance to reflect the Node.js 24.15+ prerequisite.
  • Tests

    • Updated tooling checks to validate the pinned Node.js 24.15.0 version.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@misaeldasilva123ms96-commits, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d026f98-9439-497a-8e9f-2535ebdaf7c4

📥 Commits

Reviewing files that changed from the base of the PR and between e60a5e1 and b0ea6fd.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • tests/tooling/test_dependency_security_contract.py
📝 Walkthrough

Walkthrough

Node.js now uses the pinned 24.15 release across workflows, deployment, Docker images, package engine requirements, local configuration, contributor documentation, and security workflow validation.

Changes

Node.js version alignment

Layer / File(s) Summary
Runtime version contracts
.nvmrc, .node-version, Dockerfile*, frontend/Dockerfile, js-runner/Dockerfile, package.json, frontend/package.json
Runtime images, local selectors, and Node.js engine requirements now target Node.js 24.15.
Workflow version pins
.github/workflows/*
CI, deployment, security, post-merge, and release workflows now use Node.js 24.15.0.
Documentation and validation
CONTRIBUTING.md, tests/tooling/test_dependency_security_contract.py
The contributor prerequisite and security workflow test now require Node.js 24.15.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: github_actions

Suggested reviewers: owner

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: requiring Node.js 24.15.
Description check ✅ Passed The description clearly covers the changes, motivation, validation, limitation, and merge order, but it omits several template headings and checkboxes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/node-24-15-jsdom30

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 1, 2026
@github-actions github-actions Bot added the tests label Aug 1, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Deploying projeto-omni with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0ea6fd
Status: ✅  Deploy successful!
Preview URL: https://585922eb.projeto-omni.pages.dev
Branch Preview URL: https://agent-node-24-15-jsdom30.projeto-omni.pages.dev

View logs

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Line 12: Update the Node.js version requirement in the contributing
documentation from “24.15+” to the bounded range “>=24.15 <25”, matching the
package.json contract and excluding Node.js 25 and later.

In `@frontend/package.json`:
- Line 7: Update the Node.js version selected by .node-version from 24.14.1 to
24.15.0 so it matches the package engine requirement and Dockerfile
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 35d74297-bc76-40c7-a9a8-c77168abd440

📥 Commits

Reviewing files that changed from the base of the PR and between 3cbf1df and d18ccad.

⛔ Files ignored due to path filters (2)
  • frontend/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (23)
  • .github/workflows/ci.yml
  • .github/workflows/deploy.yml
  • .github/workflows/frontend-ci.yml
  • .github/workflows/lint.yml
  • .github/workflows/manual-full-validation.yml
  • .github/workflows/omni-live-e2e-ci.yml
  • .github/workflows/omni-node-ci.yml
  • .github/workflows/omni-public-demo-ci.yml
  • .github/workflows/omni-python-ci.yml
  • .github/workflows/omni-runtime-ci.yml
  • .github/workflows/omni-security-ci.yml
  • .github/workflows/post-merge.yml
  • .github/workflows/release.yml
  • .github/workflows/security.yml
  • .nvmrc
  • CONTRIBUTING.md
  • Dockerfile
  • Dockerfile.demo
  • frontend/Dockerfile
  • frontend/package.json
  • js-runner/Dockerfile
  • package.json
  • tests/tooling/test_dependency_security_contract.py

Comment thread CONTRIBUTING.md Outdated
Comment thread frontend/package.json
@misaeldasilva123ms96-commits

Copy link
Copy Markdown
Owner Author

Pendências encerradas no SHA 188f020a37849f4d421551e22ab9d3630f316cde: duas observações do CodeRabbit corrigidas e resolvidas; Node permanece fixado em 24.15.0; o contexto obrigatório build-and-test-js-python (24.x, 3.11) foi preservado explicitamente; todos os checks obrigatórios estão verdes. PR pronto para decisão de merge manual pelo Misael.

@misaeldasilva123ms96-commits
misaeldasilva123ms96-commits merged commit e911f1f into main Aug 1, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant