Skip to content

Roll back the PR-self-check-in guard and draft-merge workaround - #152

Merged
missingbulb merged 1 commit into
mainfrom
claude/nike-claudonite-bootstrap-x47z09
Jul 7, 2026
Merged

Roll back the PR-self-check-in guard and draft-merge workaround#152
missingbulb merged 1 commit into
mainfrom
claude/nike-claudonite-bootstrap-x47z09

Conversation

@missingbulb

@missingbulb missingbulb commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Closes #154. Closes #151.

Two Claude-side settings that drove PR churn — draft-by-default PRs and Autofix pull requests (auto-subscribe + hourly self-check-in) — have been turned off at the source. The guards the corpus grew to smooth those over now guard a phantom, so this removes them.

Removed

  • checks/pretooluse-guard.mjs — the deferred-self-check-in branch (send_later / ScheduleWakeup / create_trigger). The remote-branch-delete guard stays (real, still-valid environment guard).
  • .claude/settings.json + bootstrap.md — PreToolUse matcher back to Bash.
  • checks/test/guard.test.mjs — the self-check-in fixtures.
  • skills/merge-to-main — the "un-draft before merging" step (added earlier this session); PRs are no longer opened as draft.

Kept

Verification

  • node checks/run.mjs — clean (exit 0).
  • node --test checks/test/*.test.mjs — 64/64 pass (guard tests now cover only the delete-branch case).

Net diff vs main: 5 files, +21 / −71.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HzjetxNGYuN5wwF1vRdkA8

Two Claude-side settings that drove PR churn — draft-by-default PRs and
"Autofix pull requests" (auto-subscribe + hourly self-check-in) — have been
turned off at the source. The guards the corpus grew to smooth those over now
guard a phantom, so remove them:

- checks/pretooluse-guard.mjs: drop the deferred-self-check-in branch
  (send_later / ScheduleWakeup / create_trigger). The remote-branch-delete
  guard stays.
- .claude/settings.json + bootstrap.md: PreToolUse matcher back to `Bash`.
- checks/test/guard.test.mjs: drop the self-check-in fixtures.
- skills/merge-to-main: drop the "un-draft before merging" step — PRs are no
  longer opened as draft.

Kept from the lessons pass: the get_status-misses-Actions-CI gotcha in
git-github-advanced — reading CI via check runs is setting-independent.

Closes #154. Refs #151.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HzjetxNGYuN5wwF1vRdkA8
@missingbulb
missingbulb force-pushed the claude/nike-claudonite-bootstrap-x47z09 branch from 30427bb to d5ae313 Compare July 7, 2026 10:44
@missingbulb missingbulb changed the title Lessons: reading Actions CI status, and un-drafting before merge Roll back the PR-self-check-in guard and draft-merge workaround Jul 7, 2026
@missingbulb
missingbulb marked this pull request as ready for review July 7, 2026 10:44
@missingbulb
missingbulb merged commit 306d555 into main Jul 7, 2026
1 check passed
@missingbulb
missingbulb deleted the claude/nike-claudonite-bootstrap-x47z09 branch July 7, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants