Drop redundant warning-suppression acceptance for vendored fixtures - #662
Merged
Merged
Conversation
The mounted Claudinite canon now carries #188, which makes the warning-suppression check skip files git marks linguist-vendored / linguist-generated (via the new ctx.vendored() helper in checks/lib/context.mjs). The cached event-page fixtures under dev/requirements/extractor/data/ are linguist-vendored, so the check now skips them on its own and the per-repo accept entry we added for them is dead weight — remove it. The deliberate eval() acceptance for dev/routines/create-extractor/test/extractor-naming.test.js stays: that is our own reviewed test code, not vendored third-party content. Verified: node .claudinite/checks/run.mjs no longer surfaces the data/**/*.html fixtures as warning-suppression findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FT8W9KiYkFvVvZi1rge5U4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the per-repo
warning-suppressionacceptance fordev/requirements/extractor/data/from.claudinite-checks.json. The deliberate-eval()acceptance fordev/routines/create-extractor/test/extractor-naming.test.jsis kept — that's our own reviewed test code, not vendored third-party content.Why
Claudinite #188 taught the
warning-suppressioncheck to skip files git markslinguist-vendored/linguist-generated, via a newctx.vendored()helper inchecks/lib/context.mjs. The cached event-page fixtures underdev/requirements/extractor/data/(recorded verbatim from the create-extractor pipeline, with the sites' own inlineeslint-disable-style comments in their markup) arelinguist-vendored. Now that the mounted canon carries #188, the check skips them on its own, so the per-repo acceptance we added for them is dead weight.Verification
ctx.vendored()exists in.claudinite/checks/lib/context.mjsandpacks/universal/warning-suppression.mjscalls it tocontinuepast vendored files.node .claudinite/checks/run.mjsdoes not surface thedata/**/*.htmlfixtures aswarning-suppressionfindings after removing the acceptance — the synced check skips them itself.pack-declarationblocking about the newly-syncedexecutable-requirementspack is present both before and after this change and is out of scope here.)🤖 Generated with Claude Code
Generated by Claude Code