Skip to content

Conversation

@missionmike
Copy link
Collaborator

@missionmike missionmike commented Aug 2, 2025

Description

Attempts to fix a bash issue with the tag release workflow.


Important

Fixes syntax error in .github/workflows/tag-version.yml to correctly handle non-merge push events.

  • Workflow:
    • Fixes syntax error in .github/workflows/tag-version.yml by changing the conditional statement for if to use startsWith() function correctly.
    • Ensures the job only runs on non-merge push events by checking if the commit message does not start with 'Merge pull request'.

This description was created by Ellipsis for c0a28dd. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Aug 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ampdresume 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 2, 2025 5:21am

@missionmike missionmike merged commit e65cdaa into main Aug 2, 2025
3 of 4 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to c0a28dd in 1 minute and 17 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/tag-version.yml:16
  • Draft comment:
    The string literal 'Merge pull request' appears to be split across two lines. This may cause syntax issues. Please ensure the entire string is on the same line or use proper multi-line string syntax if supported.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% GitHub Actions YAML files do handle multi-line strings in a specific way. The indentation and line continuation here appears to be valid YAML syntax. GitHub Actions specifically supports this kind of line wrapping in conditions. I've seen many GitHub Actions workflows with similar formatting that work perfectly fine. I might be wrong about YAML's handling of line continuations in this specific context. There could be edge cases where this causes issues. While YAML can be tricky, this specific format is common in GitHub Actions workflows and is a valid syntax pattern. The workflow would fail immediately if this was problematic. The comment should be deleted as it raises a non-issue. This is valid YAML syntax that GitHub Actions supports.

Workflow ID: wflow_L2MKjdUmj3zxat8U

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

runs-on: ubuntu-latest
# Only run on push if it's not from a merged PR (to avoid duplicate runs)
if: github.event_name != 'push' || github.event.head_commit.message !~ /^Merge pull request/
if:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'if' expression is now split across multiple lines without proper YAML literal formatting, which likely causes a parsing error. Instead, use a single-line expression (or a proper block scalar) such as:

if: github.event_name != 'push' || !startsWith(github.event.head_commit.message, 'Merge pull request')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants