Skip to content

Conversation

@missionmike
Copy link
Collaborator

@missionmike missionmike commented Aug 29, 2025

Thank you for submitting a PR! Please review & check the boxes below:

  • I have filled in the "Description" section below.
  • I have provided manual testing steps and screenshots (if applicable).
  • My code is covered by automated tests.

Description

Updates Cypress test suite to use .ts files instead of .js

Steps to Test

Checkout local, run npm run build and npm start followed by npm run test:cypress:

image

Important

Convert Cypress test suite from JavaScript to TypeScript, updating file extensions and adding TypeScript references and types.

  • File Renames:
    • Rename .js files to .ts in cypress/integration/navigation, cypress/integration/theme/davids, cypress/integration/theme/default, cypress/pages, and cypress/support.
  • TypeScript Integration:
    • Add /// <reference types="cypress" /> to all .ts files for TypeScript support.
    • Add type annotations in themeDavidsPage.cy.ts and e2e.ts.
    • Create index.d.ts to declare custom Cypress commands.
  • Configuration Changes:
    • Update cypress.config.js to use supportFile: "./cypress/support/e2e.ts".

This description was created by Ellipsis for 6c51dde. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ampdresume Ready Ready Preview Comment Aug 29, 2025 0:28am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 6c51dde in 43 seconds. Click for details.
  • Reviewed 173 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. cypress.config.js:63
  • Draft comment:
    SpecPattern still targets .js files while tests have been converted to .ts. Update this to './cypress/**/*.cy.ts' to ensure all tests are discovered.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. cypress/integration/navigation/primaryMenu.cy.ts:19
  • Draft comment:
    Concatenating BASE_URL with '/login' using the || operator may yield an unexpected URL if BASE_URL is undefined. Consider using (Cypress.env('BASE_URL') || '') + '/login'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. cypress/integration/navigation/homepage.cy.ts:9
  • Draft comment:
    Using an arbitrary wait (cy.wait(1000)) can lead to flakiness. Consider waiting for a specific element or event for more reliable test behavior.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_66c09GIpeRcoK0zI

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@missionmike missionmike merged commit f70b6e5 into develop Aug 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants