Holiday goodies #60
Merged
Holiday goodies #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename main.yaml to build.yaml - Replace custom prep script with docker/metadata-action - Remove paths-ignore (not needed for tag-based releases) - Add semver tags (v1.0.0, v1.0, v1) - Add sha tag for traceability
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Mailgun API client from v3 to v5 and introduces comprehensive testing infrastructure with mocks, along with modernizing the CI/CD pipeline using release-please for automated releases.
Key Changes:
- Upgraded
mailgun-godependency from v3 to v5, requiring API usage refactoring - Added dependency injection through a
MailgunClientinterface to enable testing with mocks - Implemented comprehensive test suite with 95%+ code coverage using mockery-generated mocks
- Replaced manual GitHub Actions workflow with release-please automation
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated mailgun-go to v5.9.0 and added testify for testing |
| main.go | Refactored to use MailgunClient interface and v5 API methods |
| mailgun_client.go | New file implementing MailgunClient interface wrapping v5 API |
| mocks/mock_mailgun_client.go | Generated mock implementation for testing |
| exporter_test.go | Comprehensive test suite covering success and error scenarios |
| release-please-config.json | Configuration for automated release management |
| .release-please-manifest.json | Current version tracking for release-please |
| .mockery.yaml | Configuration for mock generation |
| Makefile | Added test and generate targets |
| .github/workflows/build-publish.yaml | New unified workflow for builds, tests, and releases |
| .github/workflows/create-release.yaml | Workflow for automated release PR creation |
| .github/workflows/main.yaml | Removed old workflow file |
| .vscode/settings.json | Added empty VS Code settings file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add MailgunClient interface to enable mocking - Create mailgun_client.go with interface and wrapper implementation - Generate mocks with mockery v3 - Add comprehensive tests for Exporter: - TestNewExporterWithClient - TestExporter_Describe - TestExporter_Collect_Success - TestExporter_Collect_GetDomainsError - TestExporter_Collect_GetMetricsError - TestExporter_Collect_DomainState - TestExporter_Collect_NilMetricValues - add test job and Makefile targets - Add 'make test' target (runs fmt check + go test) - Add 'make generate' target (runs mockery) - Add test job to CI that runs before binary builds
BREAKING CHANGE: MG_DOMAIN environment variable is no longer required. The exporter now uses the new ListMetrics API instead of the deprecated GetStats API. All Prometheus metrics remain unchanged.
xbglowx
force-pushed
the
holiday-goodies
branch
from
298d242 to
58e59c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.