Skip to content

Conversation

@arthurkehrwald
Copy link

@arthurkehrwald arthurkehrwald commented Jan 20, 2025

I installed the latest versions of grpcio, grpciotools and protobuf, regenerated the platform interface scripts using mpf/platforms/visual_pinball_engine/generate.py and tested it with VPE.

Fixes #1864

Copy link
Collaborator

@avanwinkle avanwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're generally reticent to roll package upgrades because they can cause downstream issues, but all the tests passed and we gotta do it sometime, right?

Thanks for taking care of this!

@arthurkehrwald
Copy link
Author

I've added a new RPC to the service definition. It is a simple ping function that I will use in the VPE integration to check if MPF is ready. Previously, VPE simply waited for 1,5 seconds and assumed it was ready, but this can fail on slow computers and wastes time on fast ones. GRPC provides ways to wait for the connection to be ready that would be preferrable, but they are not supported on grpc-dotnet with .netstandard2.1.

@sonarqubecloud
Copy link

@arthurkehrwald
Copy link
Author

I've added the MPF version to the ping response so VPE can accommodate different versions of MPF in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pip installation of VPE dependencies fails on Python >3.9

2 participants