fix: remove line breaking mypinballs segment displays

[unRARed]

This might be another naive PR from our side, but we have been trying to get our "mypinballs" segment displays going and have been running into a strange issue. The displays were initializing as expected, but any value we entered only ever displayed " 0" and was the case for all 4 displays we're running. I reached out to the guy who wrote the MyPinballs firmware and he provided instructions for the formats the displays expect which is as such:

Control Code : Display ID : Integer Value to Display

So to display a score of 500 on the 2nd display, the value is 1:2:500. We were able to confirm our displays are working by simply connecting from the terminal as such: echo "1:1:1234567\n" > /dev/ttyACM1.

With this confirmed, we looked at the MyPinballs mpf source and noticed this curious piece:

# special char for spaces
text = text.replace(" ", "?")

As a hunch, I removed the line... and instantly our attract values displayed. Further, starting a game reinitialized the displays and switch hits were scoring. I'm wondering if there are perhaps different versions of the MyPinballs segment display controller or maybe other updates downstream broke the existing implementation? Anyone else running these displays that could test against the 0.57.x branch and report back?

[avanwinkle]

Thanks for figuring this out!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[avanwinkle]

Change seems simple enough but some tests have broken as a result, hopefully it's straightforward for you to resolve!

[unRARed]

Sorry, this wasn't ready to be merged. In the PR description, I mentioned:

I'm wondering if there are perhaps different versions of the MyPinballs segment display controller or maybe other updates downstream broke the existing implementation? Anyone else running these displays that could test against the 0.57.x branch and report back?

So I suspect the sketch that's on the Arduino that MyPinballs ships changed at some point. I think @jabdoa2 wrote that code originally. Is he still contributing? Does anyone else have this hardware? I could delete those tests for the line we removed, but that might break the integration with the older versions (again, assuming it changed at some point).

[jabdoa2]

I think I wrote this based on some spec. Not sure if I actually have the hardware. If this does not work on real hardware with recent firmware just change it.