fix: reuse if there is already defined custom element#958
Open
Donggggg wants to merge 1 commit intomissive:mainfrom
Open
fix: reuse if there is already defined custom element#958Donggggg wants to merge 1 commit intomissive:mainfrom
Donggggg wants to merge 1 commit intomissive:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
em-emoji-picker) is already defined, use it to create an instance.Reason for Changes
In
emoji-mart-react, an instance is created using custom element(Picker) during initial rendering.If my application has more than 2 packages using emoji-mart, I get into trouble in the following scenario.
emoji-martin the first package, the custom element(em-emoji-picker) is defined because it has never been defined.emoji-mart/packages/emoji-mart/src/components/Picker/PickerElement.tsx
Lines 30 to 34 in 16978d0
emoji-martin the second package, the custom element(em-emoji-picker) is already defined, so it does not defined.To fix this issue, I added guard logic to reuse custom element that is already defined.
Issues
#812