-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Restore AppLockService to wrap acquireApObjectLock #16897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
60
commits into
develop
Choose a base branch
from
copilot/sub-pr-16099
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+886
−708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- メンテナンスされないredis-lockを自前実装に変更 - 既にロックされている場合のリトライ間隔を調整
…nd-update-dependencies
This reverts commit c508318.
…github.com/misskey-dev/misskey into renovate/major-backend-update-dependencies
This reverts commit 54f1fc3.
…nd-update-dependencies
1 task
Co-authored-by: syuilo <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix major dependency updates
Restore AppLockService to wrap acquireApObjectLock
Nov 30, 2025
Base automatically changed from
renovate/major-backend-update-dependencies
to
develop
November 30, 2025 00:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restores
AppLockServiceas a DI-based wrapper around the distributed lock functions, replacing directacquireApObjectLockcalls in AP services.AppLockService.tswithgetApLock()andgetChartInsertLock()methodsApNoteServiceandApInboxServiceto useAppLockServiceinstead of injecting Redis directlyCoreModule.tsBefore:
After:
Why
Per @syuilo's request: cleaner implementation with Redis instance managed via DI rather than passed manually to lock functions. Services needing AP object locking no longer need direct Redis injection.
Additional info (optional)
Build verified. No new security issues (CodeQL clean).
Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.