Skip to content

Fix truncation not keeping the last message per the documented rule #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Osamaali313 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix truncation not keeping the last message per the documented rule #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mistral_common/tokens/tokenizers/instruct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,9 @@ def drop(idx: int) -> None:
if idx == last_user_message_index:
# never drop the last user message
return
if idx == len(messages) - 1:
# never drop the last message
return
tok = tokenized_messages[idx]
assert tok is not None
to_drop -= len(tok)
Expand Down