Skip to content

Conversation

@patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 21, 2024

Most tokenizer exception arguably come from the message being empty. Currently this gives the following error message:

'Invalid assistant message: '

which looks a bit incomplete. I think it'd be better to throw:

'Empty assistant message.'

@patrickvonplaten patrickvonplaten changed the title Update sentencepiece.py Make assistant tokenization error message more specific Apr 21, 2024
@patrickvonplaten patrickvonplaten requested a review from Bam4d April 21, 2024 12:17
@patrickvonplaten patrickvonplaten requested review from jean-malo and removed request for jean-malo August 4, 2024 17:04
@juliendenize
Copy link
Contributor

Related method has been moved to instruct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants