ci: add lint and type check workflow#116
Open
abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
Open
Conversation
Add GitHub Actions workflow running ruff, black, and mypy checks on pushes to main and pull requests. Uses the existing tool configurations in pyproject.toml and requirements.dev.txt. Note: This file should be moved to .github/workflows/lint.yml to activate the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions CI workflow for automated code quality checks.
What it does
pyproject.toml)pyproject.toml)pyproject.toml)Important: File Placement
The workflow file is placed at
.github/lint-workflow.ymlinstead of.github/workflows/lint.ymldue to GitHub token scope limitations during PR creation. To activate the workflow, simply move the file:Alternatively, a maintainer with the
workflowscope can move the file directly.Why
The project has
ruff,black,mypy, andpytestconfigured inpyproject.tomland listed inrequirements.dev.txt, but no CI automation to enforce them. This workflow runs the lint checks on every push tomainand on pull requests.What's NOT included (by design)
DUMMY_MODELpath, so they cannot run on free GitHub-hosted runners. A GPU-enabled test job could be added later with self-hosted runners.Configuration
main+ all pull requests tomain