Fix generate_mamba() argument error in interactive mode #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #220 - TypeError when running Mamba models in interactive mode.
Root Cause: The
interactive()function was passingimagesas a positional argument to bothgenerate()andgenerate_mamba(), but their signatures differ:generate(encoded_prompts, model, images, *, ...)- accepts images as 3rd positional arggenerate_mamba(encoded_prompts, model, *, ...)- does NOT accept images (Mamba models don't support vision)The Fix: Use separate code paths for Transformer and Mamba models in
interactive():Changes
src/mistral_inference/main.py: Separate branches for Transformer vs Mamba ininteractive()tests/test_main_generate_dispatch.py: Regression tests verifying function signaturesTest Plan
generate_mamba()doesn't acceptimagesparametergenerate()acceptsimagesas positional parameterBefore (crash)
After (works)
Mamba models generate correctly in interactive mode without the images argument.