Skip to content

bug: skip sessions with invalid environment metadata - #946

Open
fallintoplace wants to merge 1 commit into
mistralai:mainfrom
fallintoplace:fix/invalid-session-environment
Open

bug: skip sessions with invalid environment metadata#946
fallintoplace wants to merge 1 commit into
mistralai:mainfrom
fallintoplace:fix/invalid-session-environment

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • validate session environment metadata before accessing it
  • keep missing and null environments compatible by normalizing them to an empty object
  • skip corrupted sessions without hiding valid sessions
  • cover both session listing and cwd-filtered discovery

Tests

  • uv run pytest tests/session/test_session_loader.py tests/acp/test_list_sessions.py -q
  • uv run pyright vibe/core/session/session_loader.py tests/session/test_session_loader.py
  • uv run pre-commit run --all-files

@fallintoplace
fallintoplace requested a review from a team as a code owner July 27, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant