fix(solver): Fix Hermite-to-power representation conversion#23
Open
flandyjohn wants to merge 1 commit into
Open
fix(solver): Fix Hermite-to-power representation conversion#23flandyjohn wants to merge 1 commit into
flandyjohn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @kotakondo, thank you for the great work!
I was playing around with MIGHTY and I noticed that the quintic piecewise polynomial trajectories published are not$C²$ continuous at the segment boundaries.
This seems to be due to a bug in the conversion from the Hermite to power-basis representation in
SolverLBFGS::getPieceWisePol, where the some time terms are missing.In particular, these lines:
mighty/src/mighty/lbfgs_solver.cpp
Lines 1632 to 1634 in 03c54ae
Should be changed to:
I've tested these changes locally and I can now get$C²$ polynomial trajectories at the output.
Let me know what you think.