-
Notifications
You must be signed in to change notification settings - Fork 17
[WIP] Support Blockly v12 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I tested this PR and it doesn't work for multiple selections |
|
Yes, that's why it's working in progress (WIP). Any help to get this working would be much appreciated. |
fd83d4e to
c84cb31
Compare
|
Blockly v12 node focus changes have a significant conflict with the nature of this plugin. Now I've made some patches to Blockly v12: RaspberryPiFoundation/blockly#9261 So that it can at least work with the plugin in this PR when you multiselect and drag the blocks, but I'm sure it's broken for many other behaviors for both Blockly itself and the plugin. I'll discuss this with the Blockly team to find out if there's a possible workaround. |
|
Any news? @HollowMan6 |
|
Hi @TannerGabriel! You can find information on how to implement this properly at https://groups.google.com/g/blockly/c/7RSn9cXAulA. Unfortunately, I don't have bandwidth right now to work on this issue, but if you are interested, feel free to take over this PR/continue the discussion under that Google Groups thread. |
Signed-off-by: Hollow Man <[email protected]>
Signed-off-by: Hollow Man <[email protected]>
51ff9ce to
004f9c6
Compare
|
@HollowMan6 is this something you're interested in and have time to continue working on in the near future? If not I have some time to take it on. I noticed you made some changes a few months ago, if you're interested in my taking it over would you be able to provide a quick update as to where it stands and whether you're blocked by anything on Blockly end? Thanks! |
|
Hi @mjgallag ! I'm happy to hear that and feel free to take this over as unfortunately I don't think I have time in the near future to continue working on this PR. There isn't really any updates after the discussions in: https://groups.google.com/g/blockly/c/7RSn9cXAulA I think we will still need to talk with the Blockly Team about the design to see how they can accommodate for the multi-select plugin. |
Resolve #103