Skip to content

review LlamaRotaryEmbedding usage #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ classifiers = [
dependencies = [
"accelerate==0.34.2", "sentencepiece", "tokenizers>=0.12.1",
"torch==2.3.0", "torchvision==0.18.0",
"transformers==4.46.0",
"transformers==4.48.3",
"lm_eval==0.3.0", "texttable",
"toml", "attributedict",
"protobuf",
Expand Down
6 changes: 3 additions & 3 deletions tinychat/models/llama.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import torch.nn.functional as F
import awq_inference_engine
from transformers.models.llama.modeling_llama import LlamaRotaryEmbedding
from transformers import LlamaConfig

# from flash_attn.flash_attn_interface import flash_attn_unpadded_func

Expand Down Expand Up @@ -156,9 +157,8 @@ def __init__(self, args):
.half()
) # added to half
# dummy
self.rotary_emb = LlamaRotaryEmbedding(
self.head_dim, max_position_embeddings=2048, device="cuda:0"
)
cfg = LlamaConfig(head_dim=self.head_dim, max_position_embeddings=2048)
self.rotary_emb = LlamaRotaryEmbedding(cfg, device="cuda:0")

def forward(
self,
Expand Down
1 change: 0 additions & 1 deletion tinychat/models/mpt.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from torch import nn
import torch.nn.functional as F
import awq_inference_engine
from transformers.models.llama.modeling_llama import LlamaRotaryEmbedding

# from flash_attn.flash_attn_interface import flash_attn_unpadded_func

Expand Down
1 change: 0 additions & 1 deletion tinychat/modules/fused_attn.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from torch.nn import functional as F
from transformers.models.llama.modeling_llama import (
LlamaAttention,
LlamaRotaryEmbedding,
apply_rotary_pos_emb,
)
from typing import Optional
Expand Down