Fix apply_readout_error to use correct qubit mapping #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed c2p_mapping (classical to physical) to c2v_mapping (classical to virtual) in apply_readout_error methods to match the measurement module's behavior and correctly apply readout errors to the logical qubit indices. Fixes mit-han-lab#223 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed
c2p_mapping(classical to physical) toc2v_mapping(classical to virtual) inapply_readout_errormethods across all NoiseModel classes.This aligns the noise model's behavior with the measurement module which correctly uses
v_c_reg_mapping["c2v"]for mapping classical measurement results to logical qubit indices.Changes
NoiseModelTQ.apply_readout_error()(line 477)NoiseModelTQPhase.apply_readout_error()(line 716)NoiseModelTQPhaseReadout.apply_readout_error()(line 762)Test plan
Fixes #223
🤖 Generated with Claude Code