Fix NoiseDevice buffer device placement - #321
Open
yurekami wants to merge 1 commit into
Open
Conversation
Added .to(self.device) when initializing the density tensor in NoiseDevice to match the behavior of QuantumDevice. Previously, NoiseDevice buffers would remain on CPU even when device='cuda' was specified, causing device mismatch errors when loading state dictionaries or using the device on GPU. This fixes issues where: - model.load_state_dict() fails with device mismatch - GPU-based noise simulations fail unexpectedly - State dicts saved from GPU models can't be loaded Fixes mit-han-lab#210 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
.to(self.device)when initializing the density tensor inNoiseDeviceto match the behavior ofQuantumDevice.Problem
NoiseDevicebuffers remained on CPU even whendevice='cuda'was specified:This caused:
model.load_state_dict()to fail with device mismatch errorsSolution
Added
.to(self.device)to the density tensor initialization, consistent withQuantumDevice.Test plan
Fixes #210
🤖 Generated with Claude Code