Add state validation to QuantumDevice.set_states() #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
check_legalityparameter toset_states()that validates:Problem
As noted in #305, users can set states with mismatched batch sizes or unnormalized states without any warning, leading to confusion and incorrect results.
Solution
Add opt-in validation with informative warnings:
The device's
bszis updated to match the input states' batch size.Test plan
Fixes #305
🤖 Generated with Claude Code