Update user.h #266
Closed
Update user.h #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
pull |
echtwerner
suggested changes
Oct 7, 2024
echtwerner
left a comment
echtwerner
left a comment
There was a problem hiding this comment.
This Change seems to be part of PR #264 upto #268.
In my opinion you should combine all changes into 1 PR, cause they are related and should be reviewed in once.
BTW I implemented the same function in october 2023, it seems to be natural to have the desire to get freepages and freemem.
But I believe since xv6-riscv is a learning OS, they want not to implement this changes into the source code. te
Anyway it would be good if the maintainer of this repo would close PR's which wont get accepted.
Member
|
Thanks, but we don't see the educational value for us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.