Fix redundant MIE_STIE enable in timerinit (Issue #422) #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

n0tShayan wants to merge 1 commit into mit-pdos:riscv from n0tShayan:fix-redundant-timer-enable

n0tShayan commented Dec 4, 2025

This PR removes the redundant w_mie(r_mie() | MIE_STIE); line in timerinit().

Reason:

Timer interrupts are already enabled in start() via SIE_STIE.
The interrupt is delegated to S-mode, so only SIE matters.
The MIE_STIE write in timerinit() is redundant and unnecessary.

This follows the RISC-V spec and discussion in Issue #422.

Closes: #422


          Update start.c

1df5a75

Remove redundant MIE_STIE enable in timerinit (fix Issue mit-pdos#422)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet