Skip to content

[CI] [MacOS] Enable JSOO again#2117

Merged
JasonGross merged 3 commits into
masterfrom
enable-jsoo-macos
Jul 14, 2025
Merged

[CI] [MacOS] Enable JSOO again#2117
JasonGross merged 3 commits into
masterfrom
enable-jsoo-macos

Conversation

@JasonGross

@JasonGross JasonGross commented Jul 6, 2025

Copy link
Copy Markdown
Collaborator

As per 4986ba9#r161506462, jsoo.6.1.0 includes significant memory usage improvements, and will hopefully work even work even with M1 GH Action runners which have only 7GB RAM.

cc @hhugo

@JasonGross JasonGross enabled auto-merge (squash) July 6, 2025 02:54
@JasonGross

Copy link
Copy Markdown
Collaborator Author

@hhugo do you know what's going on with the wasm_of_ocaml failure? Does wasm_of_ocaml --source-map --no-inline src/ExtractionJsOfOCaml/WithBedrock/fiat_crypto.byte no longer produce src/ExtractionJsOfOCaml/fiat_crypto.wat (and instead produce files in src/ExtractionJsOfOCaml/fiat_crypto.assets or something?)

@hhugo

hhugo commented Jul 6, 2025

Copy link
Copy Markdown
  • we not longer emit textual wat files unless --debug wat is provided. Emitting it is slow and binaryen tools are slow reading it.
  • the latest jsoo release 6.1 requires OCaml 4.13 at least. You should bump ocaml-compiler version for the jsoo job.
  • you should experiment removing --no-inline

@JasonGross JasonGross disabled auto-merge July 6, 2025 17:41
@JasonGross JasonGross enabled auto-merge July 6, 2025 17:41
@hhugo

hhugo commented Jul 6, 2025

Copy link
Copy Markdown

How does that look ?

 0m23.01s | 1814688 ko | ExtractionJsOfOCaml/bedrock2_fiat_crypto.js

coq-docker.yml still uses 4.11.1

As per 4986ba9#r161506462, jsoo.6.1.0 includes significant memory usage improvements, and will hopefully work even work even with M1 GH Action runners which have only 7GB RAM.
@JasonGross JasonGross disabled auto-merge July 14, 2025 19:30
@JasonGross JasonGross merged commit 347865b into master Jul 14, 2025
20 of 22 checks passed
@JasonGross JasonGross deleted the enable-jsoo-macos branch July 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants