This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add a recovering decode hook #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooks are difficult to get 100% correct. When there is an error in the code using reflection, we are likely to trigger a panic. While a panic is helpful to the developer, an end-user has no clue where the problem is and they don't know what part of the configuration would need to be tweaked to work around the issue. The proposed recovering decode hook will turn the panic into an error, which is a more user-friendly way to report the error to an end user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks are difficult to get 100% correct. When there is an error in the code using reflection, we are likely to trigger a panic. While a panic is helpful to the developer, an end-user has no clue where the problem is and they don't know what part of the configuration would need to be tweaked to work around the issue.
The proposed recovering decode hook will turn the panic into an error, which is a more user-friendly way to report the error to an end user.