Adding dropdown menu for choosing Edx endpoint #965
Conversation
static/js/lib/collection.js
Outdated
| @@ -67,6 +69,7 @@ export function makeInitializedForm( | |||
| adminChoice: adminChoice, | |||
| adminLists: _.join(collection.admin_lists, ","), | |||
| edxCourseId: collection.edx_course_id, | |||
| edxEndpoint: collection.edx_endpoints[0], | |||
There was a problem hiding this comment.
Is it possible for edx_endpoints to be empty?
|
What would be the possible values in the dropdown and what users they will be shown for ? If I'm a member from XPro team, would I see the MITx Online option ? |
|
@Ferdi In django admin you can add CollectionEdxEndpoint instances to make the endpoint an available choice to pick from. Only edx endpoints that are linked to a collection through CollectionEdxEndpoint will be available to the user in the collection form ui. |
|
The dropdown menu appears for anyone in this group EDX_ADMIN_GROUP(edX Course Admin). This is the same condition as for setting the edx course id for the collection. |
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 95.91% 95.87% -0.05%
==========================================
Files 182 184 +2
Lines 7269 7339 +70
Branches 253 254 +1
==========================================
+ Hits 6972 7036 +64
- Misses 262 268 +6
Partials 35 35
Continue to review full report at Codecov.
|
collinpreston
force-pushed
the
master
branch
from
e5e282f to
f8e3d0d
Compare
Pre-Flight checklist
What are the relevant tickets?
none
What's this PR do?
Adding a dropdown menu in the collection edit form dialog for choosing an edx installation for posting uploaded videos.
How should this be manually tested?
Create a collection, set up couple of EdxEndpoint instances, and a corresponding CollectionEdxEnpoints. When you go to edit the collection you should see a menu for selecting available edx installations for your collection.