Update overlay.rb for SV-261937 #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds overlay logic for SV-261937. Rather than psql --version, it uses SHOW server_version, querying directly into the server. The original STIG assumed a hosted instance, whereby the psql and server versions are stated, but the later won't state with an RDS instance - you'll only get the version of the psql binary on your InSpec runner.
georgedias
approved these changes
Jun 18, 2025
georgedias
requested changes
Jun 19, 2025
Contributor
georgedias
left a comment
georgedias
left a comment
There was a problem hiding this comment.
Please review my updated comment and suggestion.
| end | ||
| end | ||
|
|
||
| control 'SV-261937' do |
Contributor
There was a problem hiding this comment.
after further reviewing the control, I believe we should change it to the following:
control 'SV-261937' do
min_org_allowed_postgres_version = input('min_org_allowed_postgres_version')
installed_postgres_version = command('psql --version').stdout.split[2]
# If no organization specified postgres version was given, inform the user to manually review the control for proper major and minor release versions
if (min_org_allowed_postgres_version.nil? || min_org_allowed_postgres_version.empty?)
describe "Your installed Postgres version is: #{installed_postgres_version}. You must review this control manually or set / pass the 'min_org_allowed_postgres_version' to the profile. The latest supported releases can be found at http://www.postgresql.org/support/versioning/" do
skip "Your installed Postgres version is: #{installed_postgres_version}. You must review this control manually or set / pass the 'min_org_allowed_postgres_version' to the profile. The latest supported releases can be found at http://www.postgresql.org/support/versioning/"
end
else
sql = postgres_session(input('pg_dba'), input('pg_dba_password'), input('pg_host'), input('pg_port'))
describe sql.query('SHOW server_version;', [input('pg_db')]) do
its('output') { should cmp >= min_org_allowed_postgres_version }
end
end
end
Contributor
There was a problem hiding this comment.
ok, I think this one is ready to merge
georgedias
approved these changes
Jun 19, 2025
| end | ||
| end | ||
|
|
||
| control 'SV-261937' do |
Contributor
There was a problem hiding this comment.
ok, I think this one is ready to merge
Signed-off-by: skarikar <[email protected]>
Signed-off-by: skarikar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overlay logic for SV-261937. Rather than psql --version, it uses SHOW server_version, querying directly into the server. The original STIG assumed a hosted instance, whereby the psql and server versions are stated, but the later won't state with an RDS instance - you'll only get the version of the psql binary on your InSpec runner.