Accept local package-lock.json as target #1116
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirilldogU
force-pushed
the
kusubyan/package-lock-json-target-support
branch
from
764dc3d to
5bed196
Compare
j-lanson
reviewed
Apr 9, 2025
hipcheck/src/cli.rs
Outdated
Comment on lines
901
to
917
| #[derive(Debug, Clone, clap::Args)] | ||
| pub struct CheckPackageLockJsonArgs { | ||
| /// package-lock.json to analyze | ||
| pub path: String, | ||
| } | ||
|
|
||
| impl ToTargetSeedKind for CheckPackageLockJsonArgs { | ||
| fn to_target_seed_kind(&self) -> Result<TargetSeedKind> { | ||
| let path = PathBuf::from(&self.path); | ||
| if path.exists() { | ||
| if self.path.ends_with("package-lock.json") { | ||
| return Ok(TargetSeedKind::Multi(MultiTargetSeedKind::PackageLockJson( | ||
| path, | ||
| ))); | ||
| } | ||
| } | ||
| Err(hc_error!("The provided package-lock.json does not exist")) | ||
| } | ||
| } |
There was a problem hiding this comment.
@alilleybrinker thoughts on adding PackageLockJson as a supported hc check subcommand? Since we are trying to deprecate the hc check repo invocation style, and the method for detecting package lock json files is so straightforward, we could eschew adding hc check package-lock-json and force-rely on the target kind detection.
Only drawback is that we can't allow people to coerce the target kind, the file will always have to be named package-lock.json
@KirilldogU not saying to remove this yet
|
Kirill, can you fix the linting issue on this branch? |
Signed-off-by: Kirill Usubyan <[email protected]>
KirilldogU
force-pushed
the
kusubyan/package-lock-json-target-support
branch
from
5bed196 to
69fb0cb
Compare
alilleybrinker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR until resolving and analyzing Multi-target seeds in parallel is implemented.
Code contains functionality to accept, parse, and convert to a MultiTargetSeed a local package-lock.json.